Fix pac proxy agent support #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pimterry
force-pushed
the
fix-pac-file-support
branch
from
a8e856d
to
52c6912
Compare
|
Had to do a little update to TypeScript to handle some recent changes elsewhere, but that's all now sorted! Thanks for the contribution @smckee-r7 😄. In case you're not aware, HTTP Toolkit Pro is actually free for all contributors to repos in this org - I've just set that up now, linked to the email from your Git commits. If that's useful to you, just download HTTP Toolkit, click 'Get Pro' then 'Log into existing account' and enter your email. Thanks again! I'll release this as Mockttp v3.15.3 shortly. |
|
Thanks @pimterry, great stuff! Also really cool, I'll check it out when I get the chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
proxyUrlis broken when trying to use an external PAC file (#179). This small PR fixes this to allowproxyUrlto reference an external PAC file and have it be handled correctly.