-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Mini USB connector with USB-C #27
base: master
Are you sure you want to change the base?
Conversation
@hsgw Would you be able to take a look if the PCB looks OK? I copied the USB-C schematic from the Discipline project, so that should be good. Thanks! |
Hi, I know there is through hole type-c connector and it's not difficult to soldering too much. Thanks |
@hsgw Hey, I did include the schematic symbol in I just updated the PR, looks like I had the associations and the library path wrong. Can you please test again? The connector I used is a through-hole one - see the DigiKey link in the PR description. It is indeed pretty easy to solder; I built one Discipline v1 with it. Just out of curiosity, which connector did you have in mind? |
I just opened an issue in the Discipline repo to find out what's the origin/license of the USB-C connector schematic symbol/footprint: coseyfannitutti/discipline#34 |
OK! I can see type-c symbol on schematic.
If we can't use them, I can make our own library. |
Pinged Bryan from CFTKB by e-mail and received the following response:
I've also received prototype USB-C Plaid PCBs from JLCPCB today, will try to build one to confirm it's working correctly. |
Thanks! I've thought a lot about ensuring that it works correctly. I am really sorry and very grateful for your contribute. |
I completely understand that. I wouldn't expect you to merge it just like that. I also want to ensure the PCB works correctly. I'm currently having PCBs made and will build one when the next revision arrives. (I should have perhaps opened the PR only after testing, but I was also looking for possible feedback.) Once I confirm that the PCB works correctly, would you perhaps be open to merging my contribution into a separate branch ( |
d125691
to
4546deb
Compare
Ladies and gentlemen, it's alive! 😊 The second revision works correctly (don't even ask about the first revision... 😉). Latest revision has been pushed to my fork.
|
Thanks so much! |
slightly off topic, any chance to add a kailh hotswap branch? |
@fi0 I guess that wouldn't be too difficult - all the switch footprints would need to be replaced and re-routed. I have loads of Kailh sockets, so might have a go at it soon. |
Replace the Mini USB connector with a through-hole USB-C one. I used Discipline keyboard as inspiration. Fixes #22.
To make the slightly larger connector and the two extra resistors fit I had to move the I2C header and the LEDs to the right.
I had to cherry-pick the "fix library name in sch" commit (2d1dfa1) to fix many components showing with "??" in the schematic.
I included gerber zip for anyone who wants to inspect it. I realize the original repo doesn't contain the gerbers but it might be a good idea to start including them so that people don't have to generate them themselves when ordering boards.
This is my first go at modifying a PCB in KiCad, so I would appreciate any input. I did my best to keep all the existing features (like extra copper zones where traces meet pads).