You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, thanks for this amazing project. It really makes me excited about web development again!
Bug
As I was using it to build my first iOS application, I noticed a bug that causes my application to work like this:
Go to a page that supports pagination
Click a pagination link to go the next page (page 2)
Refresh the page
Result: the refreshed page is page 1
Expected result: the refreshed page is page 2
I think this happens because I'm using <turbo-frame> with data-turbo-action attribute as "advance" and it is not being respected, so the navigation works fine, but the URL doesn't change and a refresh sends us back to the initial page that rendered the original turbo-frame.
Basically, I'm expecting this to work natively as well, so correct me if I'm wrong on that assumption: https://turbo.hotwired.dev/handbook/frames#promoting-a-frame-navigation-to-a-page-visit.
Steps to reproduce
Run an app that has a turbo-frame with navigation promoted to page visit
Open the demo app from this repo on Xcode, point to the application from above and run it
Navigate to a page that has pagination
Go to the next page
Pull to refresh the page and see it go back to the previous page instead of refreshing the current page
Hey, thanks for this amazing project. It really makes me excited about web development again!
Bug
As I was using it to build my first iOS application, I noticed a bug that causes my application to work like this:
I think this happens because I'm using <turbo-frame> with
data-turbo-action
attribute as "advance" and it is not being respected, so the navigation works fine, but the URL doesn't change and a refresh sends us back to the initial page that rendered the original turbo-frame.Basically, I'm expecting this to work natively as well, so correct me if I'm wrong on that assumption: https://turbo.hotwired.dev/handbook/frames#promoting-a-frame-navigation-to-a-page-visit.
Steps to reproduce
I created this tiny Rails app that can be used to test it: https://github.com/nunesmatheus/turbo-frame-promote-visit-demo.
I just ran
rails new
and added a simple page with pagination links inside a turbo frame that promotes navigation to page visits: nunesmatheus/turbo-frame-promote-visit-demo@950dcd9.The text was updated successfully, but these errors were encountered: