This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Modify user group report results logic #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Due to the API endpoint upgrade, user stats can be retrieved directly - Remove redundant userGroup feature-count-and-filter util function - Map relevant stats directly to keys in data aggregation function
|
I will wait until - hotosm/insights#23 this fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the API endpoint upgrade here -> hotosm/galaxy-api#213, the results returned are already filtered to reflect the keys used on the User Group Report.
Hence this PR removes the redundant filter logic and maps the keys directly to the aggregated array used in displaying the User Group Report Results.