Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom ODK submission media upload with official external storage (S3) #1894

Draft
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Related to
#1875
#1701
will impact
#1706

Describe this PR

  • Configure Central so submission media automatically syncs to S3 (24hr schedule).
  • Optionally trigger the sync on a more frequent interval (perhaps whenever submissions are requested).
  • Implement some additional async functions in osm-fieldwork OdkCentralAsync to handle getting all pre-signed URLs for media attached to a submission.
  • Replace custom logic in backend API with logic from osm-fieldwork to get the submission media pre-signed URLs via S3.
  • Return the pre-signed URLs to the frontend for display.

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock added ODK Any requests for optimizing ODK dependency:osm-fieldwork Requires updates in osm-fieldwork labels Nov 18, 2024
@spwoodcock spwoodcock requested a review from Sujanadh November 18, 2024 02:50
@github-actions github-actions bot added docs Improvements or additions to documentation enhancement New feature or request backend Related to backend code devops Related to deployment or configuration contrib labels Nov 18, 2024
@spwoodcock spwoodcock force-pushed the feat/central-s3-media branch from ac99aa0 to df2d5e4 Compare November 21, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code contrib dependency:osm-fieldwork Requires updates in osm-fieldwork devops Related to deployment or configuration docs Improvements or additions to documentation enhancement New feature or request ODK Any requests for optimizing ODK
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants