Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The newly merged branch contains some problems that need further improvements #29

Open
honglu2875 opened this issue Jul 18, 2022 · 1 comment
Assignees

Comments

@honglu2875
Copy link
Owner

small amount of duplicated codes in GameMorin

class GameMorin(Game):

The efficiency of ZeillingerLex can be dramatically improved

class ZeillingerLex(Zeillinger):

WeakSpivakovsky does not seem to have a proper test

class WeakSpivakovsky(Host):

all README.md may need some updates.

—— low priority ——
AgentMorin only supports 1 single batch of input.
It might not be necessary to generalize to multiple batches at all. So I would say the priority of this one is pretty low.

class AgentMorin(Agent):

_thom_snippets.py might also need some further cleanup (e.g. my comments) and clarifications in docstring.

@honglu2875 honglu2875 changed the title The newly merged branch contains some problems that need further fixes The newly merged branch contains some problems that need further improvements Jul 18, 2022
@honglu2875
Copy link
Owner Author

duplicated codes in GameMorin is solved in branch refine_host_and_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants