Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --chrome option #30

Open
qpakzk opened this issue Mar 21, 2023 · 6 comments
Open

Add --chrome option #30

qpakzk opened this issue Mar 21, 2023 · 6 comments

Comments

@qpakzk
Copy link

qpakzk commented Mar 21, 2023

Do you think it is necessary to add --chrome option for viewing heap trace info on the Chrome tracing similar to uftrace dump --chrome?

@Bojun-Seo
Copy link
Collaborator

I think --chrome feature you suggested will be very useful.

@honggyukim
Copy link
Owner

Hi @qpakzk,

I'm glad to see you here and thanks for your suggestion.

However, chrome trace viewer is timeline based but our heap profiling data doesn't keep the timeline history. We should keep accumulate the snapshot image of the heap profile data across the timeline. Do you have any good idea on that?

@qpakzk
Copy link
Author

qpakzk commented Mar 21, 2023

@honggyukim I just ask whether similar features in uftrace can be applied to heaptrace.

@honggyukim
Copy link
Owner

honggyukim commented Mar 21, 2023

The heap profiling data is a collection of many stack traces at some specific time so I think the timeline view is not suitable in this case. Thanks for your suggestion anyway!

@honggyukim
Copy link
Owner

@qpakzk You might be interested in https://youtube.com/watch?v=HKQR7wVapgk&feature=shares.

It explains about the difference between flame graph and flame chart whether they are timeline based or not.

@qpakzk
Copy link
Author

qpakzk commented Mar 21, 2023

@honggyukim Thanks for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants