Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alarm filtering (suppressions) feature #23

Open
Bojun-Seo opened this issue Mar 8, 2023 · 4 comments
Open

Add alarm filtering (suppressions) feature #23

Bojun-Seo opened this issue Mar 8, 2023 · 4 comments

Comments

@Bojun-Seo
Copy link
Collaborator

Bojun-Seo commented Mar 8, 2023

Sometimes user wants to remove some reports which are not necessary to be trace.
So I suggest to add alarm filtering feature.
Like suppressions feature on llvm-project Sanitizers
https://github.com/google/sanitizers/wiki/AddressSanitizerLeakSanitizer#suppressions

@honggyukim
Copy link
Owner

We can support it but it might take a while if I have to do. Would you like to try that?

@Bojun-Seo
Copy link
Collaborator Author

OK great, I will make a patch soon.

@Bojun-Seo Bojun-Seo changed the title Add false alarm filtering (suppressions) feature Add false filtering (suppressions) feature Mar 9, 2023
@Bojun-Seo Bojun-Seo changed the title Add false filtering (suppressions) feature Add alarm filtering (suppressions) feature Mar 9, 2023
@Bojun-Seo
Copy link
Collaborator Author

I'm currently implementing this feature.
Followings are the draft patch.
Bojun-Seo@cdd04b6
And I have two issues on this patch.

  1. I copied TemplateMatch function from llvm-project, so I need to check license issue.
  2. Duplicated symbol resolving issue
    is_suppressed flag sets on record_backtrace function(this patch, resembles llvm-project).
    Symbol resolving is needed to do this on here. But symbol will be resolved on printing phase later.
    So duplicated symbol resolving will be happened with this patch.
    It could be possible to eliminate this duplication by caching symbols,
    Or just check suppressions on printing phase with already resolved symbols.

@Bojun-Seo
Copy link
Collaborator Author

I implement this feature.
#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants