Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file permissions are 0755 instead of 0640 after codegen #27

Open
graste opened this issue Aug 29, 2016 · 0 comments
Open

file permissions are 0755 instead of 0640 after codegen #27

graste opened this issue Aug 29, 2016 · 0 comments

Comments

@graste
Copy link
Member

graste commented Aug 29, 2016

The files generated are 0750 atm while they should be 0640. They're then deployed via copy or move operation and then have 0755 in the target folder of the application. The codecache folder has the permissions wanted when the FILE_MODE constant is changed to 0640, but the deployed files are not adhering to that. Reason is the Symfony Filesystem component as that introduced in v2.7.x a change to only "keep executable permission when a file is copied" (as in Unix' ls). Further on: setting the file mode when dumping a file has been deprecated in 2.x and has been removed in 3.x.

Suggestions:

  • set default FILE_MODE to 0640
  • don't set permissions on dumpFile anymore
  • chmod afterwards on generated/deployed files
graste added a commit to honeybee/honeybee-agavi-cmf-vendor that referenced this issue Aug 29, 2016
make dumpFile call compatible with Symfony Filesystem 3.x.

See honeybee/trellis#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant