App-icon found but not extracted anymore in version 2.3.1

[eithor]

Describe the bug
After upgrade to recipe-robot 2.3.1 the icons are no longer saved with the recipes. I'm asking for jamf-upload, download and package recipes. I guess technically the icon is not needed for those recipes that are created, but I will change the jamf-upload to a more full Jamf recipe, including upload of the icon.

To Reproduce
Steps to reproduce the behavior:

1. Ask recipe-robot to create recipes for any app, for jamf-upload+download+pkg
2. Observe in the verbose output that recipe-robot finds the icon
3. See that icon is not extracted and saved with the recipe output

Expected behavior
Icon is saved with the recipe output like in previous versions of recipe-robot

Screenshots
Debug run of Postman recipe creation:

% /Applications/Recipe\ Robot.app/Contents/Resources/scripts/recipe-robot --ignore-existing -v https://dl.pstmn.io/download/latest/osx_64 --debug
[WARNING] Will build recipes even if they already exist in "autopkg search" results. Please don't upload duplicate recipes to public AutoPkg repos on GitHub.

                      -----------------------------------
                     |  Welcome to Recipe Robot v2.3.1.  |
                      -----------------------------------
                                \   _[]_
                                 \  [oo]
                                   d-||-b
                                     ||
                                   _/  \_

Processing: https://dl.pstmn.io/download/latest/osx_64
Input path looks like a download URL.
    Download URL is: https://dl.pstmn.io/download/latest/osx_64
Downloading file for further inspection...
######################################################################################################################################################################################################################################################### 100.0%
    [DEBUG] Curl command: ['/usr/bin/curl', '--compressed', '--location', '--show-error', '--progress-bar', '--output', '/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64', '--url', 'https://dl.pstmn.io/download/latest/osx_64']
    Downloaded to /Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64
Determining download format...
[WARNING] At this point I'm still not sure what the download format is. I'll try guessing, but this could cause problems later.
Trying file as a disk image...
    [DEBUG] Shell command: /usr/bin/hdiutil imageinfo -plist "/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64"
    [DEBUG] Shell command: /usr/bin/hdiutil attach -nobrowse -plist "/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64"
[DEBUG] Unable to mount /Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64. (hdiutil: attach failed - diskfil ikke gjenkjent
)
(You can ignore this message if the upcoming attempt to unzip the downloaded file as an archive succeeds.)
Trying file as an archive...
    [DEBUG] Shell command: /usr/bin/unzip "/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/osx_64" -d "/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/unpacked"
    Successfully unarchived zip
Validating app...
    This app seems valid
Getting bundle name...
    Bundle name is: Postman
Getting bundle identifier...
    Bundle identifier is: com.postmanlabs.mac
Checking for a Sparkle feed...
    No Sparkle feed
Looking for version key...
    Version key is: CFBundleShortVersionString (10.19.7)
Looking for icon...
    Icon is: /Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/unpacked/Postman.app/Contents/Resources/app.icns
Getting description...
    [DEBUG] Curl command: ['/usr/bin/curl', '--compressed', '--location', '--silent', '--show-error', '--url', 'https://www.macupdate.com/find/mac/context=Postman']
    Description (from MacUpdate.com): Securely share, sync and collaborate on your APIs.
Gathering code signature information...
    [DEBUG] Shell command: /usr/bin/codesign --display --verbose=2 -r- "/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/unpacked/Postman.app"
    Code signature verification requirements recorded
    3 authority names recorded
    Developer: Postdot Technologies, Inc
    Team ID: H7H8Q7M5CK
Generating download recipe...
    /Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman.download.recipe
Generating pkg recipe...
    /Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman.pkg.recipe
Generating jamf recipe...
[REMINDER] Remember to manually set the category in the jamf recipe. I've set it to "Productivity" by default.
    /Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman-pkg-upload.jamf.recipe

You've created 205 recipes with Recipe Robot. Very impressive.

[DEBUG] SUPPORTED FILE FORMATS:
('dmg', 'iso', 'zip', 'tar.gz', 'gzip', 'tar.bz2', 'tbz', 'tgz', 'pkg')

[DEBUG] PREFERENCES FOR THIS SESSION:
{'DSPackagesPath': None,
 'IgnoreExisting': None,
 'Initialized': True,
 'LastRecipeRobotVersion': '2.3.1',
 'RecipeCreateCount': 205,
 'RecipeCreateLocation': '/Users/eith/Library/AutoPkg/Recipe Robot Output',
 'RecipeFormat': None,
 'RecipeIdentifierPrefix': 'no.norce',
 'RecipeTypes': (
    pkg,
    download,
    jss,
    jamf
),
 'SUEnableAutomaticChecks': True,
 'SUHasLaunchedBefore': True,
 'SULastCheckTime': 2023-11-09 07:31:49 +0000,
 'SUSendProfileInfo': False,
 'StripDeveloperSuffixes': None}

[DEBUG] FACTS WE HAVE COLLECTED:
{'complete': [], 'errors': [], 'icons': [], 'information': [], 'recipes': [{'type': 'download', 'description': 'Downloads an app in whatever format the developer provides.', 'preferred': True, 'existing': False, 'keys': {'Identifier': 'no.norce.download.Postman', 'MinimumVersion': '2.3', 'Input': {'NAME': 'Postman'}, 'Process': [{'Processor': 'URLDownloader', 'Arguments': {'url': 'https://dl.pstmn.io/download/latest/osx_64', 'filename': '%NAME%.zip'}}, {'Processor': 'EndOfCheckPhase'}, {'Processor': 'Unarchiver', 'Arguments': {'archive_path': '%pathname%', 'destination_path': '%RECIPE_CACHE_DIR%/%NAME%', 'purge_destination': True}}, {'Processor': 'CodeSignatureVerifier', 'Arguments': {'input_path': '%RECIPE_CACHE_DIR%/%NAME%/Postman.app', 'requirement': 'identifier "com.postmanlabs.mac" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = H7H8Q7M5CK'}}, {'Processor': 'Versioner', 'Arguments': {'input_plist_path': '%RECIPE_CACHE_DIR%/%NAME%/Postman.app/Contents/Info.plist', 'plist_version_key': 'CFBundleShortVersionString'}}], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)', 'Description': 'Downloads the latest version of Postman.'}, 'filename': 'Postman.download.recipe'}, {'type': 'pkg', 'description': 'Creates a standard pkg installer file.', 'preferred': True, 'existing': False, 'keys': {'Identifier': 'no.norce.pkg.Postman', 'MinimumVersion': '2.3', 'Input': {'NAME': 'Postman'}, 'Process': [{'Processor': 'AppPkgCreator', 'Arguments': {'app_path': '%RECIPE_CACHE_DIR%/%NAME%/Postman.app'}}], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)', 'Description': 'Downloads the latest version of Postman and creates a package.', 'ParentRecipe': 'no.norce.download.Postman'}, 'filename': 'Postman.pkg.recipe'}, {'type': 'munki', 'description': 'Imports into your Munki repository.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'jamf', 'description': 'Imports package only into Jamf Pro. Does not create policies or groups.', 'preferred': True, 'existing': False, 'keys': {'Identifier': 'no.norce.jamf.Postman', 'MinimumVersion': '2.3', 'Input': {'NAME': 'Postman', 'CATEGORY': 'Productivity'}, 'Process': [{'Processor': 'com.github.grahampugh.jamf-upload.processors/JamfCategoryUploader', 'Arguments': {'category_name': '%CATEGORY%'}}, {'Processor': 'com.github.grahampugh.jamf-upload.processors/JamfPackageUploader', 'Arguments': {'pkg_category': '%CATEGORY%'}}], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)', 'Description': 'Downloads the latest version of Postman and uploads the package to Jamf.', 'ParentRecipe': 'no.norce.pkg.Postman'}, 'filename': 'Postman-pkg-upload.jamf.recipe'}, {'type': 'ds', 'description': 'Imports into your DeployStudio Packages folder.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'filewave', 'description': 'Imports a fileset into your FileWave server.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'lanrev', 'description': 'Imports into your LANrev server.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'sccm', 'description': 'Creates a cmmac package for deploying via Microsoft SCCM.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'bigfix', 'description': 'Builds a .bes deployment file and imports it into your BigFix console', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, {'type': 'install', 'description': 'Installs the app on the computer running AutoPkg.', 'preferred': False, 'existing': False, 'keys': {'Identifier': '', 'MinimumVersion': '1.0.0', 'Input': {'NAME': ''}, 'Process': [], 'Comment': 'Created with Recipe Robot v2.3.1 (https://github.com/homebysix/recipe-robot)'}}, '/Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman.download.recipe', '/Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman.pkg.recipe', '/Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc/Postman-pkg-upload.jamf.recipe'], 'reminders': ['Remember to manually set the category in the jamf recipe. I\'ve set it to "Productivity" by default.'], 'warnings': ['Will build recipes even if they already exist in "autopkg search" results. Please don\'t upload duplicate recipes to public AutoPkg repos on GitHub.', "At this point I'm still not sure what the download format is. I'll try guessing, but this could cause problems later."], 'args': Namespace(input_path='https://dl.pstmn.io/download/latest/osx_64', app_mode=False, config=False, debug=True, ignore_existing=True, keep_cache=False, skip_icon=False, verbose=True), 'inspections': ['archive', 'app'], 'blocking_applications': ['Postman.app'], 'codesign_authorities': ['Developer ID Application: Postdot Technologies, Inc (H7H8Q7M5CK)', 'Developer ID Certification Authority', 'Apple Root CA'], 'download_url': 'https://dl.pstmn.io/download/latest/osx_64', 'is_from_app_store': False, 'specify_filename': False, 'download_filename': 'osx_64.zip', 'download_format': 'zip', 'app_path': '/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/unpacked/Postman.app', 'app_name': 'Postman', 'bundle_id': 'com.postmanlabs.mac', 'version_key': 'CFBundleShortVersionString', 'icon_path': '/Users/eith/Library/Caches/Recipe Robot/2023-11-09_09-06-12_050835/unpacked/Postman.app/Contents/Resources/app.icns', 'description': 'Securely share, sync and collaborate on your APIs.', 'codesign_reqs': 'identifier "com.postmanlabs.mac" and anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] /* exists */ and certificate leaf[field.1.2.840.113635.100.6.1.13] /* exists */ and certificate leaf[subject.OU] = H7H8Q7M5CK', 'codesign_input_filename': 'Postman.app', 'developer': 'Postdot Technologies, Inc', 'recipe_dest_dir': '/Users/eith/Library/AutoPkg/Recipe Robot Output/Postdot Technologies, Inc', 'app_name_key': '%NAME%', 'execution_time': 0.005279356963001192}

Desktop (please complete the following information):

• macOS: 13.6.1
• Recipe Robot Version: 2.3.1
• autopkg version: 2.7.2
• /usr/local/autopkg/python --version: 3.10.4

Additional context
Same setup worked on earlier recipe-robot version