-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ring docs for camera live view #36011
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes involve updates to the documentation for the Ring integration in Home Assistant. A new section on "Realtime event stability" has been added, detailing requirements for TCP access and troubleshooting steps for Ring alerts. The support for camera entities has been clarified, specifying two entities: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant RingService
User->>HomeAssistant: Trigger doorbell event
HomeAssistant->>RingService: Notify event
RingService-->>HomeAssistant: Send event data
HomeAssistant->>User: Alert with event data
User->>HomeAssistant: Request last recording
HomeAssistant->>RingService: Fetch last recording
RingService-->>HomeAssistant: Return last recording
HomeAssistant->>User: Provide last recording
Warning Rate limit exceeded@sdb9696 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
source/_integrations/ring.markdown (1)
Line range hint
156-196
: Clarify relationship with live view functionalityThe realtime event stability section provides excellent troubleshooting steps. However, it would be helpful to clarify:
- Whether these steps are specifically relevant to the new live view functionality
- If there are any specific stability considerations when using the live view feature
🧰 Tools
🪛 Markdownlint (0.35.0)
52-52: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/ring.markdown
(5 hunks)
🔇 Additional comments (3)
source/_integrations/ring.markdown (3)
45-45
: LGTM!
The table of contents addition is properly formatted and correctly references the new section.
137-137
: LGTM!
The python script example has been correctly updated to use the last_recording
entity, maintaining consistency with the automation example.
94-108
: Consider explaining the delay configuration
The automation example includes a 5-minute delay, but it's not clear why this delay is necessary. Consider adding a comment explaining the purpose of this delay.
Additionally, this example reflects the migration from binary_sensor
to event
entity mentioned elsewhere in the documentation.
✅ Verification successful
The delay configuration is appropriate for Ring event handling
The 5-minute delay in the automation example is actually necessary as it allows time for Ring to process and make the recording available after a doorbell event. This is consistent with the migration from binary sensors to event entities, which is clearly documented as a breaking change to be completed by release 2025.4.0.
The example correctly demonstrates:
- Usage of the new event entity (
event.front_doorbell_ding
) - Proper delay timing to ensure recording availability
- Correct attribute references for the recording URL and metadata
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the consistency of entity migration documentation
rg -A 2 "binary_sensor.*event" source/_integrations/ring.markdown
Length of output: 67
Script:
#!/bin/bash
# Search for any mentions of binary_sensor and event entities in Ring documentation
rg -i "binary_sensor|event.*doorbell|doorbell.*event" source/_integrations/ring.markdown
# Also check for any migration notes or breaking changes
rg -i "migrat|breaking.change|deprecat" source/_integrations/ring.markdown
Length of output: 755
Once you have enabled the [Ring integration](/integrations/ring), you can start using the camera platform. | ||
Currently, it supports doorbells and stickup cameras. | ||
Two camera entities are provided: `live_view` and `last_recording`. | ||
`last_recording` is disabled by default. | ||
|
||
{% important %} | ||
Please note that downloading and playing Ring video will require a Ring Protect plan. | ||
Please note that downloading and playing Ring video from the `last_recording` camera will require a Ring Protect plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add clarification about camera entity differences
While the introduction of live_view
and last_recording
entities is clear, users would benefit from understanding:
- The difference between these two entities
- When to use each entity
- Any limitations or requirements specific to
live_view
Proposed change
Update ring docs for the new live view camera entity.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
live_view
andlast_recording
.Documentation
last_recording
camera.