Velbus add quality_scale.yaml #131377
Velbus add quality_scale.yaml #131377
Conversation
|
Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: done | ||
| config-flow: done |
There was a problem hiding this comment.
Some config flow steps are missing data_description.
| @@ -0,0 +1,70 @@ | |||
| rules: | |||
| # Bronze | |||
| action-setup: done | |||
There was a problem hiding this comment.
The actions are setup in async_setup_entry and the new best practice is to use async_setup.
| docs-installation-instructions: todo | ||
| docs-removal-instructions: todo | ||
| entity-event-setup: | ||
| status: exempt |
There was a problem hiding this comment.
My read is that they are subscribing to events here and do meet this requirement:
| comment: | | ||
| Entities of this integration does not explicitly subscribe to events. | ||
| entity-unique-id: done | ||
| has-entity-name: done |
There was a problem hiding this comment.
The entities do not appear to set has_entity_name attribute to true. Am I missing it?
| Entities of this integration does not explicitly subscribe to events. | ||
| entity-unique-id: done | ||
| has-entity-name: done | ||
| runtime-data: done |
There was a problem hiding this comment.
This does not appear to be met as hass.data is still being used rather than runtime_data on the config entry.
| config-entry-unloading: done | ||
| docs-configuration-parameters: todo | ||
| docs-installation-parameters: todo | ||
| entity-unavailable: done |
There was a problem hiding this comment.
Where is this happening?
| entity-unavailable: done | ||
| integration-owner: done | ||
| log-when-unavailable: done | ||
| parallel-updates: done |
There was a problem hiding this comment.
This integration does not set PARALLEL_UPDATES. This should be todo?
| docs-troubleshooting: todo | ||
| docs-use-cases: todo | ||
| dynamic-devices: done | ||
| entity-category: done |
There was a problem hiding this comment.
Should any of the sensors be diagnostic entity category?
| entity-disabled-by-default: done | ||
| entity-translations: todo | ||
| exception-translations: todo | ||
| icon-translations: done |
There was a problem hiding this comment.
I believe this is not done yet given the icon translations are not set
| stale-devices: done | ||
| # Platinum | ||
| async-dependency: done | ||
| inject-websession: done |
There was a problem hiding this comment.
Should this be exempt instead?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Add quality_scale.yaml to vvelbus
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: