Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uiprotect to 0.4.1 #119308

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Bump uiprotect to 0.4.1 #119308

merged 2 commits into from
Jun 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 10, 2024

Proposed change

changelog: uilibs/uiprotect@v0.4.0...v0.4.1

This fixes likely #117100 but I don't have a console running 4.x so I left the issue open until someone confirms

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck merged commit d74d418 into dev Jun 10, 2024
38 checks passed
@frenck frenck deleted the uiprotect41 branch June 10, 2024 16:58
frenck pushed a commit that referenced this pull request Jun 11, 2024
@frenck frenck mentioned this pull request Jun 11, 2024
@alexruffell
Copy link

alexruffell commented Jun 11, 2024

@bdraco I have a UNVR running 4.0.5 OS and Protect 4.0.33. I had several log messages related to authentication since I updated to the unsupported OS. I was able to somewhat mitigate the issue by re-authenticating using a new local user (the previous one would no longer work) and that stopped the repair issue about Unifi Protect Authentication however I still had several log messages about Protect.

Today, after updating to the latest core release that includes this fix, I deleted the Unifi Protect integration and added it back with the same HA local user and it worked flawlessly. I rebooted HA to check for Unifi Protect related logs, and there are none. If this is a sufficient test, I'd say you fixed the issue. If not, please let me know what I need to do to test it. Glad to help.

@frenck
Copy link
Member

frenck commented Jun 11, 2024

@alexruffell Let's keep track of it in: #117100

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants