Newly renamed Synology_DSM platform not setting up from YAML

[ThomasPrior]

The problem

Renamed my synologydsm sensor to synology_dsm as noted in the release docs but the platform does not get set up.

The following event is logged regarding setup of this sensor:
The synology_dsm platform for the sensor integration does not support platform setup. Please remove it from your config.

Environment

arch | x86_64
-- | --
dev | false
docker | false
hassio | false
os_name | Linux
os_version | 4.19.0-8-amd64
python_version | 3.7.3
timezone | Europe/London
version | 0.109.0
virtualenv | true

• Home Assistant Core release with the issue: 0.109.0
• Last working Home Assistant Core release (if known): 0.108.8
• Operating environment (Home Assistant/Supervised/Docker/venv): venv
• Integration causing this issue: synology_dsm
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/synology_dsm/

Problem-relevant configuration.yaml

Sensor.yaml:

  - platform: synology_dsm
    host: !secret synologydsm_host
    port: !secret synologydsm_port
    ssl: false
    name: Synology NAS
    username: !secret synology_username
    password: !secret synology_password
    monitored_conditions:
      - cpu_total_load
      - memory_real_usage
      - volume_status
      - volume_percentage_used
      - disk_temp
      - disk_smart_status

Traceback/Error logs

The synology_dsm platform for the sensor integration does not support platform setup. Please remove it from your config.

Additional information

Setting it up via the UI works, but not preferred. If the documented YAML setup is supposed to continue working this should be investigated, or if not, the documentation updated to reflect that UI configuration is the only way forward.

[probot-home-assistant]

Hey there @ProtoThis, @Quentame, mind taking a look at this issue as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[Quentame]

Hi !

Please look closely at breaking changes introduced in 0.109.0 and/or the documentation

synology_dsm is not a sensor platform anymore, it has its own integration.

Before 0.109.0:

sensor:
  - platform: synologydsm
    ...

From 0.109.0:

synology_dsm:
  - ...

This will fix your config.

[Quentame]

If you wanna help the development (mainly testing) of Synology DSM, you can register here : ProtoThis/python-synology#26

[ThomasPrior]

The breaking changes section does not mention the sensor domain at all, it only explicitly calls the renaming of the platform and the removal of name, leaving out the domain migration:

Given the YAML excerpt provided is almost exactly the same as the previous sensor configuration, I feel some extra clarity in the breaking changes would be a good thing:

configuration.yaml (new):

synology_dsm:
  - host: XXX
    username: XXX
    password: XXX

sensor.yaml (old):

synologydsm:
  - host: XXX
    username: XXX
    password: XXX

[Quentame]

Old was not as you described but as here #34858 (comment)

I mentioned it on my refactor #32704, but I'm not making releases 😉 (we see there is not platform: perhaps), and not everyone split files like you, so we should stick as all-in-one file config.yaml 😊

I personally split in an other way:

• main config dir
  • platform dirs
    • component in each platform