Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot return the thermostat to programming due to 0 no longer being an accepted temperature value #131376

Open
benedictvantrigt opened this issue Nov 23, 2024 · 6 comments · May be fixed by #132162

Comments

@benedictvantrigt
Copy link

The problem

Somewhere in the past year the behavior of Climate: Set target temperature changed for the opentherm integration (or for all integrations, I cannot evaluate that). The result is that I cannot set the temperature to 0 anymore, setting the temperature to 0 should reset the thermostat back to programming. But that is no longer possible since this change.

I have tried a customization to change the min_temp however still I cannot set the temp to 0. I think it will need to be changed in the code it self..

It seems there were changes here in the past year so it would make sense that those caused the issue?

https://github.com/home-assistant/core/blob/dev/homeassistant/components/opentherm_gw/climate.py

`class OpenThermClimate(OpenThermStatusEntity, ClimateEntity):
"""Representation of a climate device."""

_attr_supported_features = (
    ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.PRESET_MODE
)
_attr_temperature_unit = UnitOfTemperature.CELSIUS
_attr_hvac_modes = []
_attr_name = None
_attr_preset_modes = []
_attr_min_temp = 1
_attr_max_temp = 30
_attr_hvac_mode = HVACMode.HEAT
_away_mode_a: int | None = None
_away_mode_b: int | None = None
_away_state_a = False
_away_state_b = False
_enable_turn_on_off_backwards_compatibility = False
_target_temperature: float | None = None
_new_target_temperature: float | None = None
entity_description: OpenThermClimateEntityDescription`

What version of Home Assistant Core has the issue?

2024.11.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

opentherm_gw

Link to integration documentation on our website

https://www.home-assistant.io/integrations/opentherm_gw/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @mvn23, mind taking a look at this issue as it has been labeled with an integration (opentherm_gw) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of opentherm_gw can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign opentherm_gw Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


opentherm_gw documentation
opentherm_gw source
(message by IssueLinks)

@mvn23
Copy link
Contributor

mvn23 commented Nov 23, 2024

The min_temp has been 1 since at least 2019. What makes you think it changed in the past year? Maybe Home Assistant just became more vocal about the unsupported value?

I am also curious why this could be useful. I see that both TT and TC commands support the value, but I also know that the thermostat can always override the value we set manually anyway. With the TT command changes in the thermostat program will override our setting as well. We can change the command we send in the integration options (Temporary Setpoint Override Mode). In which situation would a value of 0 be useful if we already have the functionality described here?

@PierreAronnax
Copy link
Contributor

The min_temp has been 1 since at least 2019. What makes you think it changed in the past year? Maybe Home Assistant just became more vocal about the unsupported value?

The check was added in #118649

@mvn23
Copy link
Contributor

mvn23 commented Nov 28, 2024

Thanks for the reference @PierreAronnax

Since it is apparently a behavioral change in Home Assistant I am inclined to either lower the min_temp in the opentherm_gw integration or to add support for the functionality in another way (e.g. a button).
In this case the latter has my preference as we're not actually setting the target temperature to 0.

@benedictvantrigt
Copy link
Author

@mvn23 you are correct that there are other ways to set up the automations to get to the same result. But since it was working before I figured I would report it.

It would be nice to have a way to cancel the override without reverting to the transparent commands. Especially one that you can use via automations (I think a button would not be usable, only via UI right?).

@mvn23
Copy link
Contributor

mvn23 commented Nov 28, 2024

We have the button.press action for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants