Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trust_server_summary needs clearer wording #4807

Closed
NoRi2909 opened this issue Nov 13, 2024 · 3 comments · Fixed by #4842
Closed

trust_server_summary needs clearer wording #4807

NoRi2909 opened this issue Nov 13, 2024 · 3 comments · Fixed by #4842
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@NoRi2909
Copy link
Contributor

Home Assistant Android app version(s):
2024.11.4-full
Android version(s):
15
Device model(s):
Pixel 6
Home Assistant version:
2024.11.1
Last working Home Assistant release (if known):
n/a
Description of problem, include YAML if issue is related to notifications:

Currently the trust_server_summary is

Manage enabled sensors and use notification commands from this server

showing up in the server settings under "Security":

Screenshot_20241113-100850

This is a bit too unclear because with this setting active the server can not only manage already enabled sensors but enable any additional sensor remotely. That makes quite a difference and becomes more and more of a privacy concern with the Health Connect sensors being added (if location isn't already an issue).

So this at least needs to be reworded to something like

Allow this server to enable and manage sensors and send notification commands

By turning this off the user could be sure that only those sensors can be read by the server that he or she enabled in the settings on the device. Perhaps it also made sense to split this option into two for more granular control?

At least I wanted to make sure we have a correct German translation of "manage enabled sensors" in place here.

@NoRi2909 NoRi2909 added the bug Something isn't working label Nov 13, 2024
@dshokouhi dshokouhi added the good first issue Good for newcomers label Nov 13, 2024
@dshokouhi
Copy link
Member

Perhaps it also made sense to split this option into two for more granular control?

This does not sound like a good breaking change to introduce. The toggle should represent remote control of the device. No need to split things and complicate the settings more.

@NoRi2909
Copy link
Contributor Author

OK, it's just fine for me to keep a single option here. Then it's just about making it a bit clearer that the server gains full access to all sensors when this option is enabled.

@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Nov 14, 2024

A bit related to this issue as it's right below the above option, a second string you might want to adjust as well:

 Use biometric or screen lock credential to unlock app

When the user taps this option it actually asks for those credentials to enable the lock.
So it's better to express as a positive, protective feature by using

Use biometric or screen lock credentials to protect the app

So the word "lock" is still in the sentence, but it explains this as a privacy-focused feature.
And it has to be plural with "credentials" as this is prefixed with two options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants