Replace the use of stamen tiles in the repo #451
Conversation
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
| @@ -193,7 +193,7 @@ | |||
| "source": [ | |||
| "rectangles = gv.Rectangles([(0, 0, 3, 3), (12, 12, 15, 15)]).opts(fill_alpha=0.2)\n", | |||
| "box_annotator = hv.annotate.instance()\n", | |||
| "labels = gv.tile_sources.StamenLabels()\n", | |||
| "labels = gv.tile_sources.EsriImagery()\n", | |||
There was a problem hiding this comment.
Why not EsriStreet like the others?
|
It'd be nice if you could post screenshots of the new plots so we can see if the basemap colors don't confict too much with the data colors. |
Azaya89
force-pushed
the
patch-stamen292
branch
from
6a2968f
to
5406d3d
Compare
Landsat Old
Landsat new
Ml_annotator old
Ml_annotator new
Ship traffic old
Ship traffic new
|
|
Thanks @Azaya89! The comparison with the old maps doesn't really apply as the Stamen maps can no longer be loaded. You can visit for example the ML Annotator example and verify in your browser that the requests made to get the Stamen tiles fail. This example seems to have an overlay of tiles (ESRI * Stamen).
|
|
Your changes were successfully integrated in the dev site, make sure to review the pages of the projects you touched before merging this PR. |
| "tiles = hv.element.tiles.ESRI().opts(alpha=0.4, bgcolor=\"black\").opts(responsive=True, min_height=600)\n", | ||
| "labels = hv.element.tiles.StamenLabels().opts(alpha=0.7, level='glyph')\n", | ||
| "labels = hv.element.tiles.EsriUSATopo().opts(alpha=0.4, level='glyph')\n", |
There was a problem hiding this comment.
@Azaya89 the code used to overlay an ESRI base map with the Stamen Labels layer that just contains labels (https://maps.stamen.com/toner-labels/#12/37.7922/-122.2301). With these changes, it is now overlaying two ESRI base maps, which doesn't make much sense. We've also lost the labels.
Let's go through these examples next week together.
There was a problem hiding this comment.
OK, I was thinking about it in a different way. See you next week then!
There was a problem hiding this comment.
It would be great if we could find a labels-only tile set that still works, but I'm not aware of any. Failing that, I think the task is to choose an underlying tile set with labels embedded in it already in a way that is not too distracting. I do think people need labels, because otherwise it's hard to orient yourself. But with many tile sets, the labels are rendered in a way that becomes extremely busy when dense data is overlaid on them. So there's definitely some trial and error involved and tradeoffs to make.
The use of stamen tiles in the census example will be done under #430