Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gapminders #230

Open
1 task done
maximlt opened this issue Jan 10, 2023 · 2 comments
Open
1 task done

Gapminders #230

maximlt opened this issue Jan 10, 2023 · 2 comments
Labels
project_update Projects to update

Comments

@maximlt
Copy link
Contributor

maximlt commented Jan 10, 2023

  • Handle the data explicitly instead of loading it dynamically from an external URL directly from the notebook

Given the search I did last summer Gapminders was the only project that was downloading data dynamically from a notebook (e.g. pd.read_csv(external_url)). It should instead have its data better defined. I'm suggesting adding data as a data source in the downloads section of its anaconda-project.yml file. I would also be good to add a small test dataset in test_data/.

(If the data isn't heavy at all it could be added to the /data subfolder in the project directly).

@maximlt maximlt added the bug Something isn't working label Jan 10, 2023
@maximlt maximlt changed the title Gapminders: add data to the downloads section and small test dataset Project Update: Gapminders Jan 10, 2023
@maximlt maximlt changed the title Project Update: Gapminders Gapminders Jan 10, 2023
@maximlt maximlt added project_update Projects to update and removed bug Something isn't working labels Jan 10, 2023
@jbednar
Copy link
Contributor

jbednar commented Jan 20, 2023

That all sounds good, thanks!

@jtao1
Copy link
Collaborator

jtao1 commented Jun 5, 2024

In my latest PR, I removed downloading from the notebook and added a test dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project_update Projects to update
Projects
None yet
Development

No branches or pull requests

3 participants