Move version flag to main pear command
#406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was motivated by the
-vand the--sidecarbeing listend in the output frompear help sidecar. The verbose flag (-v) is only used in the mainpearcommand that I can tell.I tried moving
--sidecaras well since thesidecarcommand doesn't seem to use it (and it sounds redundant to 'Boot Sidecar' from a command to run a sidecar in the terminal), but when I did this tests no longer passed. I tracked it down to the flag being added viashell.jsand triggered bylib/tryboot.js. So I left it in for the moment, but it'd be nice to not include it inpear sidecarif it indeed doesn't do anything.