Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the handler of the option --unsafe-clear-preferences to clear both preferences and permits #356

Closed
wants to merge 5 commits into from

Conversation

maidh91
Copy link
Contributor

@maidh91 maidh91 commented Oct 12, 2024

Context

  • We would like doctor to test TrustDialog for new key
  • To do that, we need to clear all trusted keys
  • Then click/run on the key again
  • The TrustDialog should open

Summary

  • extend the handler of the option --unsafe-clear-preferences to clear both preferences and permits

Test

./pear.dev run --unsafe-clear-preferences pear://runtime
./pear.dev run pear://kpzdysqu3uqu3nz7xakidqb1ju71jbzaszxu58r3owodbujyghuy

image

@maidh91 maidh91 changed the title Add untrust handler in sidecar Add untrust handler in sidecar Oct 12, 2024
@rafapaezbas
Copy link
Contributor

awesome, can you add a test for this? You can follow the smoke test with the next additional steps:

  • Untrust the key after staging
  • Run the app and verify that the app is untrusted
  • Trust the app
  • Run the app and verify that is trusted

@maidh91 maidh91 requested a review from HDegroote October 14, 2024 11:45
@maidh91 maidh91 changed the title Add untrust handler in sidecar Extend the handler of the option --unsafe-clear-preferences to clear both preferences and permits Oct 14, 2024
@maidh91 maidh91 marked this pull request as draft October 15, 2024 12:04
@maidh91 maidh91 force-pushed the doctor-trust-dialog branch from 84fb9b8 to aac8e06 Compare October 15, 2024 12:07
@maidh91 maidh91 force-pushed the doctor-trust-dialog branch from aac8e06 to 710b1ec Compare October 15, 2024 12:20
@maidh91
Copy link
Contributor Author

maidh91 commented Oct 16, 2024

closed due to the fix from @rafapaezbas

#373 (review)

@maidh91 maidh91 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants