Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypercore.createProtocolStream(protomux) returns NoiseSteam, not the raw stream #448

Open
gmaclennan opened this issue Oct 11, 2023 · 1 comment

Comments

@gmaclennan
Copy link
Contributor

Hypercore.createProtocolStream() has slightly different behaviour when you pass it a Protomux instance instead of a raw duplex stream or a noise stream: in the latter cases it returns the raw outer stream (e.g. the noiseStream.rawStream), but when you pass a protomux instance it returns the noise stream. Not something that comes up much, but it's confusing.

@mafintosh
Copy link
Contributor

It should always return the rawstream, will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants