Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyva Theme compatibility? #60

Open
itaymesh opened this issue Feb 19, 2023 · 2 comments
Open

Hyva Theme compatibility? #60

itaymesh opened this issue Feb 19, 2023 · 2 comments

Comments

@itaymesh
Copy link

Greetings,
Does this module compatible with the Hyva theme?
Thanks
Itay
@jeroenbalk-adwise
Copy link

Hi itaymesh,

I was just looking into this because I had the same question. I tried it and it's not. This is because hints.js depends on requirejs, jquery, etc.

Since the javascript part isn't that complex, maybe it's possible to rewrite it to vanilla js and load it in a phtml or something. It will be faster and compatible.

@PascalBrouwers
Copy link
Contributor

This module is to be used for Magento based theming if I'm not mistaken.
Of course you are free to create a PR that creates some compatibility as long as it keeps working in a vanilla Magento installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@itaymesh @PascalBrouwers @jeroenbalk-adwise