Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft Picks section for mobile #455

Open
dnbute opened this issue Nov 28, 2023 · 6 comments
Open

Soft Picks section for mobile #455

dnbute opened this issue Nov 28, 2023 · 6 comments
Assignees

Comments

@dnbute
Copy link

dnbute commented Nov 28, 2023

This section of the soft-picks-advanced page does not want to behave properly at some resolutions for mobile

https://main--sunstar--hlxsites.hlx.page/healthy-thinking/soft-picks-advanced1

Examples:

  • At 900px the section has a lot of empty space at the bottom because the background picture is really tall
Screenshot 2023-11-28 at 10 33 35 Screenshot 2023-11-28 at 10 34 51
  • At 320px the section text overflows
Screenshot 2023-11-28 at 10 35 20
  • Other resolutions are a mix of the two, sometimes it looks just fine

@sdmcraft thoughts on how to tackle this? I'd ideally like to keep the green hexagons
cc @ehrro

@dnbute dnbute self-assigned this Nov 28, 2023
@sdmcraft
Copy link

  • At 900px the section has a lot of empty space at the bottom because the background picture is really tall

Does it help if we use a smaller background picture for tablet layout?

@dnbute
Copy link
Author

dnbute commented Nov 29, 2023

  • At 900px the section has a lot of empty space at the bottom because the background picture is really tall

Does it help if we use a smaller background picture for tablet layout?

It's still mobile at 900px, I tried cropping/resizing the picture directly and using that but I still face the same issues, just at different resolutions, the actual actual problem is that the background images don't really care about the content and don't resize accordingly, but for that we'd have to change the whole background image logic

@sdmcraft
Copy link

the actual actual problem is that the background images don't really care about the content and don't resize accordingly

I know and its not straightforward as we cannot define CSS styles based on content.
Alternatively, would a pattern like this help ?

@dnbute
Copy link
Author

dnbute commented Nov 29, 2023

@sdmcraft I created a draft with a CSS solution, not so sure it's the right approach though

@ehrro
Copy link

ehrro commented Nov 29, 2023

Honestly the most important part is to read the content if the image is below it it doesn't make it readable. I would say we can remove the hexagons...

@dnbute
Copy link
Author

dnbute commented Dec 18, 2023

Was attempted here #472, closed because it's not high priority and implementation wasn't behaving properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants