From 0dbdae4c94d998301443c3a2d5355064d720ab51 Mon Sep 17 00:00:00 2001 From: David Bosschaert <bosschae@adobe.com> Date: Wed, 20 Sep 2023 15:57:35 +0100 Subject: [PATCH] Fix rendering of icon on social career button --- blocks/career-apply/career-apply.css | 5 ----- blocks/career-apply/career-apply.js | 3 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/blocks/career-apply/career-apply.css b/blocks/career-apply/career-apply.css index e3803845..a6052900 100644 --- a/blocks/career-apply/career-apply.css +++ b/blocks/career-apply/career-apply.css @@ -47,11 +47,6 @@ width: 2.125rem; } -.career-apply span.icon-linkedin svg { - /* This is needed as otherwise the icon is shown twice */ - display: none; -} - @media (min-width: 62rem) { .career-apply { max-width: 45rem; diff --git a/blocks/career-apply/career-apply.js b/blocks/career-apply/career-apply.js index 1dd5d881..d370117b 100644 --- a/blocks/career-apply/career-apply.js +++ b/blocks/career-apply/career-apply.js @@ -1,5 +1,5 @@ import { getLanguage } from '../../scripts/scripts.js'; -import { decorateIcons, fetchPlaceholders } from '../../scripts/lib-franklin.js'; +import { fetchPlaceholders } from '../../scripts/lib-franklin.js'; export default async function decorate(block) { const placeholders = await fetchPlaceholders(getLanguage()); @@ -32,7 +32,6 @@ export default async function decorate(block) { const sprite = document.createElement('span'); sprite.classList.add('icon', 'icon-linkedin'); linkedin.appendChild(sprite); - decorateIcons(linkedin); buttonBar.append(linkedin); block.appendChild(buttonBar); }