Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blog Pages] Autoblock Sidebar #16

Closed
andreituicu opened this issue Oct 15, 2023 · 3 comments · Fixed by #69
Closed

[Blog Pages] Autoblock Sidebar #16

andreituicu opened this issue Oct 15, 2023 · 3 comments · Fixed by #69
Assignees
Labels

Comments

@andreituicu
Copy link
Collaborator

The sidebar has the same content for all blog pages in the same geosite (confirm with the customer)
This means that authors should not have to add it to every page. Instead it should be autoblocked on each page with the blog page template, using a fragment.

https://www.aem.live/developer/block-collection/fragment
https://www.aem.live/developer/markup-sections-blocks#auto-blocking

@florentin
Copy link
Collaborator

In #58 I've added autoblocking/fragments for blog pages (articles)
Do we also need to autoblock these page types?

@andreituicu
Copy link
Collaborator Author

Do we also need to autoblock these page types?

Good question, I asked the customer the same in https://adobe-dx-support.slack.com/archives/C05LRE7PRQ8/p1698154206957709?thread_ts=1697658221.518879&cid=C05LRE7PRQ8 . For now I can't say that I understand 100%

@andreituicu
Copy link
Collaborator Author

I would not block merging the current PR on it, so we can present it to the customer and get their feedback, based on that they might tell us: Yes, I like it like this, I want it on all other pages, or no, I want it differently on those pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants