Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKV_AWS_88 incorrectly describes violating heuristic #1003

Open
dragonfleas opened this issue Nov 25, 2024 · 0 comments
Open

CKV_AWS_88 incorrectly describes violating heuristic #1003

dragonfleas opened this issue Nov 25, 2024 · 0 comments

Comments

@dragonfleas
Copy link

Description

Document

https://github.com/hlxsites/prisma-cloud-docs/blob/main/docs/en/enterprise-edition/policy-reference/aws-policies/public-policies/public-12.adoc

Assertion

Currently the documentation for CKV_AWS_88 is incorrect, as the title labels the issue as

AWS EC2 instances with public IP and associated with security groups have Internet access

There is no heuristic as far as I can tell that is looking for the instances to have associated security groups.

Everywhere else in the original bridgecrew and checkov documentation, it explicitly only mentions an instance "having a public ip associated" and doesn't involve security groups.

If the intention is to detect based off of whether or not an EC2 instance has a public IP address/public resolvable DNS and is reachable from the internet through a security group open to 0.0.0.0/0 then the detection heuristic in the script is incorrect.

Referenced detection code

The heuristic detection code here: https://github.com/bridgecrewio/checkov/blob/main/checkov/terraform/checks/resource/aws/EC2PublicIP.py

It's explicitly only looking for public IP address assignment arguments, and not whether or not an associated security group has internet access or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant