Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-branch workers #155

Open
iansk opened this issue Sep 14, 2023 · 1 comment
Open

Per-branch workers #155

iansk opened this issue Sep 14, 2023 · 1 comment

Comments

@iansk
Copy link
Collaborator

iansk commented Sep 14, 2023

Implement per-branch workers to enable trouble-free, it-just-works previews.

Currently, if the correct book.yml isn't in place in main in the repo, preview pages can fail to load. Although there's a well-known work-around, the users for previews are often not very technical and/or don't know about, or even care about how the backend works. In this case, it takes a number of non-obvious steps to get previews working.

We're open to a paid CloudFlare workers plan, if necessary.

@maxakuru maxakuru removed their assignment Sep 18, 2023
@iansk
Copy link
Collaborator Author

iansk commented Oct 15, 2023

Example of a use case where the single worker system gets tripped up:

  • Renaming product version directory from 30-xx to 30 - With this rename, previews completely break. The book.yml needs to be checked into main for it to work. For a normal writer, this isn't a straight forward operation, and they'll easily get tripped up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants