Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

588-add-onetrust-entity #589

Merged
merged 1 commit into from
Dec 28, 2024
Merged

588-add-onetrust-entity #589

merged 1 commit into from
Dec 28, 2024

Conversation

davenichols-DHLS
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #588

Test URLs:

@davenichols-DHLS davenichols-DHLS linked an issue Dec 19, 2024 that may be closed by this pull request
Add OneTrust entity #588
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 19, 2024 •
edited
Loading

Page Scores Audits Google
📱 /us/en/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /us/en/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

solaris007
solaris007 approved these changes Dec 21, 2024
View reviewed changes
Copy link
Contributor

@solaris007 solaris007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seem to duplicate the code addition three times. centralize in a function?

@davenichols-DHLS davenichols-DHLS merged commit 4459214 into main Dec 28, 2024
2 checks passed
@davenichols-DHLS davenichols-DHLS deleted the 588-add-onetrust-entity branch December 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solaris007 solaris007 solaris007 approved these changes

@dzehnder dzehnder Awaiting requested review from dzehnder

@krizel4 krizel4 Awaiting requested review from krizel4

@mhaack mhaack Awaiting requested review from mhaack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OneTrust entity
2 participants
@davenichols-DHLS @solaris007