ASSETS-88896 : (Backend) Campaign Details: Collections #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MH: Added Firefly product to AA Modal 'Product' Field List
…exName, page = 0) to get the Collections for a specified Campaign and Index /blocks/adp-infinite-results-campaign-collections : Block component to show the Campaign Collections as Cards
…index name from the polaris.js function getSearchIndex() CollectionsDatasource.js : updated to remove the indexName parameter from the function listCampaignCollections
|
…Everyone Can',pageNumber);
to const list = await listCampaignCollections('gmo-campaignName:Everyone Can',this.pageNumber);
shiv-gup
reviewed
Apr 4, 2024
scripts/collections.js
Outdated
| highlightPostTag: '__/ais-highlight__', | ||
| highlightPreTag: '__ais-highlight__', | ||
| hitsPerPage: 40, | ||
| maxValuesPerFacet: 20, |
There was a problem hiding this comment.
@TyroneAEM can you remove maxValuesPerFacet attribute. This is not needed
shiv-gup
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the JIRA issue(s) your PR is for, as well as a description of your changes:
Workfront Task https://experience.adobe.com/#/@wfadoberm/so:adoberm-Production/workfront/task/65f1417f000707b860ef5b592bf483ac/overview
Test URLs:
https://assets-88896--adobe-gmo--hlxsites.hlx.page/drafts/tyrone/testpage
I created a test page in word document /drafts/tyrone/testpage.docx
https://adobe.sharepoint.com/:w:/r/sites/HelixProjects/_layouts/15/Doc.aspx?sourcedoc=%7B0CEA8450-1F62-4AD0-8474-80C6BE615A57%7D&file=testpage.docx&action=default&mobileredirect=true
Which uses the new block component
adp-infinite-results-campaign-collectionsThe only thing that is hardcoded right now in the calling the new collections.js function listCampaignCollections(campaignName, page = 0)
Which is called from
blocks/adp-infinite-results-campaign-collections/CollectionsDatasource.jsI hardcode the campaign name
const list = await listCampaignCollections('gmo-campaignName:Everyone Can',pageNumber);The campaignName will be passed later in the page showing the Campaign Collections