release notes for PR connamara#830

hlibman-connamara · Jun 11, 2024 · 21096db · 21096db
1 parent ddc0e3e
commit 21096db
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/QuickFIXn/Logger/ILogFactory.cs b/QuickFIXn/Logger/ILogFactory.cs
@@ -19,8 +19,8 @@ public interface ILogFactory
     /// This log will
     /// (1) only be used for messages that cannot be linked to a session
     /// (2) only have its OnEvent() method called
-    /// (3) only be created when the first message is logged (to avoid e.g. empty log files)
-    /// This log is written to only on rare occasions.  It's possible you may never see it created.
+    /// (3) only be created when a message is logged (to avoid empty log files)
+    /// Messages are written to this log only on rare occasions.  It's possible you may never see it created.
     /// </summary>
     /// <returns></returns>
     ILog CreateNonSessionLog();

diff --git a/QuickFIXn/Session.cs b/QuickFIXn/Session.cs
@@ -396,7 +396,7 @@ public void Disconnect(string reason)
                 }
                 else
                 {
-                    Log.OnEvent("Session {SessionID} already disconnected: {reason}");
+                    Log.OnEvent($"Session {SessionID} already disconnected: {reason}");
                 }
 
                 if (_state.ReceivedLogon || _state.SentLogon)

diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -60,6 +60,11 @@ What's New
      * Also refactor the heck out of DateTimeConverter & tests: many functions renamed/deprecated
 * #847 - remove setting MillisecondsInTimeStamp (gbirchmeier)
      * Use TimestampPrecision instead (same as QF/j)
+* #830 - replace ClientThreadHandler "Debug" logs with NonSessionLog (gbirchmeier)
+     * ILogFactory extended with a `CreateNonSessionLog()`.  Pretty easy to implement though.
+     * Some classes were internalized, but I can't imagine people are using them in their app code.
+     * See details/explanation at https://github.com/connamara/quickfixn/pull/830
+
 
 **Non-breaking changes**
 * #400 - added DDTool, a C#-based codegen, and deleted Ruby-based generator (gbirchmeier)
-Original file line number
+Diff line change
@@ Expand Up / @@ -396,7 +396,7 @@ public void Disconnect(string reason) @@
                     }
                     else
                     {
-                        Log.OnEvent("Session {SessionID} already disconnected: {reason}");
+                        Log.OnEvent($"Session {SessionID} already disconnected: {reason}");
                     }
                     if (_state.ReceivedLogon || _state.SentLogon)
@@ Expand Down @@