Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

Test develop branch #90

Open
jonathanbossenger opened this issue Apr 16, 2020 · 13 comments
Open

Test develop branch #90

jonathanbossenger opened this issue Apr 16, 2020 · 13 comments

Comments

@jonathanbossenger
Copy link
Collaborator

Calling all active participants/users of this plugin template.

I've recently merged all PRs that could be merged into the develop branch. Before merging these changes into master, I'd like to have some folks test the plugin template out, to make sure it still works as expected, as well as with the new changes.

If one of your PR's was merged, please do test out your specific change.

Once I have a some feedback on this ticket, I will be able to make a call to merge the changes.

Thank you

@jonathanbossenger
Copy link
Collaborator Author

pinging

@E-Baker
@alekseyn1
@carl-alberto
@cornelRaiu

Also @hlashbrooke if you have some time :-)

@cornelRaiu
Copy link

@jonathanbossenger I just tested my PR and it seems to work perfectly.
Everything else seems to work as well.

@theEricDevelops
Copy link
Contributor

Looks good for me!

@carl-alberto
Copy link
Collaborator

Looking good to me so far

@jonathanbossenger
Copy link
Collaborator Author

Thanks for the feedback everyone. I will look at merging these changes into the master branch shortly.

In another note, I want to try and see if we can put together a little community around this plugin template, and start looking at how we could get it to the same level of usage/interest as the WP Plugin Boiler Plate, but using more modern methods, similar to how WP Rig has done for themes (namespaces, autoloading, block ready etc etc).

Would you all be interested in starting a Slack instance to get this moving?

@alhoseany
Copy link

This is a great idea. count me in.
thanks

@alhoseany
Copy link

I have created multiple fields for the plugin like, Query table, file upload, image search and even ajax buttons. Once I have some free time I will create a PR.
Screenshots:
https://prnt.sc/s19lg4
https://prnt.sc/s19nea

@hlashbrooke
Copy link
Owner

This is all working for me - nice job everyone!

I think a community around this is a great idea :) happy to assist with that in any way I can.

@cornelRaiu
Copy link

Hi everyone!
Yes, this is an awesome idea!
I am going to use this template in some of the plugins I want to develop and launch in the WP repo this year and rewrite the one I already launched.

Furthermore, I will build all the plugins on live coding streams so that will be some nice exposure to the template.

It would be nice to see this one growing.

@carl-alberto
Copy link
Collaborator

Yeah, happy to have a community around this project! Let's do this! How do we start @jonathanbossenger ? :)

@jonathanbossenger
Copy link
Collaborator Author

Glad to hear everyone is excited about this. For now, just join the slack team I just created here

https://join.slack.com/t/wp-plugin-workspace/shared_invite/zt-dlbdpxk6-WVeY_M7K16nMF5XosTC9rA

I'll start a document next week with my ideas for the project, and we can go from there.

@jonathanbossenger
Copy link
Collaborator Author

@alantygel and anyone else, I've just merged one more PR into develop, please give everything one more test, if it's all fine, I can merge the changes in master. Thanks

@ricklambrechts
Copy link

Hi,

Today i was starting a new wordpress plugin project and was using the development branch for testing.

The whole time i was tinking that the build-plugin.sh script was not working using Git Bash and other terminals i tried. It was showing me this error bash: [: ==: unary operator expected. But then after a few hours, i realised. Wait.. maybe i shoud type the Class name, because the file names renamed are missing the class name.
So after typing the class name, of course.. no problem.

Maybe the README.md needs an update now because of the added Class name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants