Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search by only ID (for search by reference) #225

Open
3 tasks done
projkov opened this issue Nov 30, 2024 · 1 comment
Open
3 tasks done

Add search by only ID (for search by reference) #225

projkov opened this issue Nov 30, 2024 · 1 comment
Assignees
Labels
1.0.0-ballot 1.0.0-ballot version of the IG bug Something isn't working ci-build CI BUILD of the IG Prioroty::Medium suite-0.0.15 0.0.15 version of the AU FHIR Core Inferno suite

Comments

@projkov
Copy link
Collaborator

projkov commented Nov 30, 2024

According to the specification, the responder SHALL support search by resourceType/id and id. In the current implementation only search by resourceType/id.

Add search by id.

The issue was found in the context of working on this issue: #208

Where to check:

  1. Encounter -> location
  2. Observation -> patient
  3. PractitionerRole - organization
@projkov projkov added bug Something isn't working Prioroty::Medium 1.0.0-ballot 1.0.0-ballot version of the IG ci-build CI BUILD of the IG suite-0.0.15 0.0.15 version of the AU FHIR Core Inferno suite labels Nov 30, 2024
@projkov projkov self-assigned this Nov 30, 2024
@projkov projkov moved this to In progress in Inferno Testing Framework Nov 30, 2024
projkov added a commit that referenced this issue Dec 2, 2024
@projkov
Copy link
Collaborator Author

projkov commented Dec 2, 2024

For the "patient" search parameters, the US Core Inferno Suite has a specific behavior. It's described in these files. If you want to check them, please check them in the suggested order:

  1. first_search? && search_param_names.include?('patient')
  2. perform_reference_with_type_search(params, resources_returned.count) if test_reference_variants?
  3. def perform_reference_with_type_search(params, resource_count)

As you can see this search parameter suite will make a search request with resourceType/id only when it is the first search. We can remove it or keep it as it is.

This is the theme to discuss with @ir4y on tomorrow's call on 3 December.

@projkov projkov moved this from In progress to In review in Inferno Testing Framework Dec 2, 2024
projkov added a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0-ballot 1.0.0-ballot version of the IG bug Something isn't working ci-build CI BUILD of the IG Prioroty::Medium suite-0.0.15 0.0.15 version of the AU FHIR Core Inferno suite
Projects
Status: In review
Development

No branches or pull requests

1 participant