Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong string used in posting time #25

Open
daveyboond opened this issue May 29, 2014 · 3 comments
Open

Wrong string used in posting time #25

daveyboond opened this issue May 29, 2014 · 3 comments

Comments

@daveyboond
Copy link

renderer.php uses get_string('early', 'assignment',...) to get the word "early", to add to the posting time. For example: "(16 mins 25 secs early)"

This is not correct English. The word should be "ago", e.g. "(16 mins 25 secs ago)"

I think you need to add a new string to the local lang file to deal with this.

@drachels
Copy link

I disagree. In the context of posting before the question is due, "early" is the correct word to use.

@daveyboond
Copy link
Author

Well it would be, if that were the context, but it's not. If I post a question, then return to the page 5 minutes and 25 seconds later, it will say "(5 minutes 25 secs early)". The word should be "ago".

Besides, there is no "due" time for this activity.

@drachels
Copy link

I see what you mean now. I had always just glanced at those times and made the assumption they referred to Allow Access Until, but now I agree with you. It definitely should be "ago" instead of early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants