Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve BNSv2 names instead of BNSv1 names on the explorer #1906

Open
314159265359879 opened this issue Nov 12, 2024 · 5 comments
Open

Resolve BNSv2 names instead of BNSv1 names on the explorer #1906

314159265359879 opened this issue Nov 12, 2024 · 5 comments
Assignees

Comments

@314159265359879
Copy link

Is your feature request related to a problem? Please describe.
Using two BNS contracts to resolve, this would cause confusion. The community is quickly adopting the BNSv2 contract because of the improvements (such as allowing more than one name per address and listing from a wallet non-custodially).

Leather is only displaying the BNSv2 name since version 6.52.0 and hiding the v1 name (and hiding the airdrop with the mistake). Although I do think it makes sense for users on marketplaces and explorers to still see the BNSv1 names, they may still hold collectors' value.
Gamma.io and Tradeport are also working on supporting BNSv2 instead.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Resolving to Stacks addresses in the explorer search bar should only resolve to the BNSv2 names to prevent confusion.
Image

Additionally it would be great if in the sandbox explorer a link was added to the BNSv2 address (instead or in addition to the BNS contract in the genesis address): SP2QEZ06AGJ3RKJPBV14SY1V5BBFNAW33D96YPGZF.BNS-V2

Image

Describe alternatives you've considered
Resolving both and letting the user choose if they want to check the Stacks address associated with the BNSv1 name or the one associated with the BNSv2 name.

I think it is better to regard BNSv2 as the BNS contract, BNSv1 is the legacy contract which is no longer used or only until everyone has migrated and adopted the BNSv2 contract. I think it would be great if Hiro can help lead the way.

@Snazzy-888
Copy link

Important! Thanks Werner.

@He1DAr He1DAr self-assigned this Nov 13, 2024
@andresgalante andresgalante moved this from 🆕 New to 📋 Backlog in Stacks Explorer Nov 18, 2024
@He1DAr He1DAr self-assigned this Nov 20, 2024
@He1DAr
Copy link
Collaborator

He1DAr commented Nov 20, 2024

@zone117x do we have a new API that supports bns2? e.g. get address that is associated with a particular bns name?

@zone117x
Copy link
Member

IIUC bns2 is all on-chain now, so likely involve RPC contract-calls and maybe NFT related endpoints. I'm not sure though, I'd recommend taking a look at the bnsv2 spec or code.

@diwakergupta
Copy link
Member

@zone117x do we have a new API that supports bns2? e.g. get address that is associated with a particular bns name?

https://github.com/Strata-Labs/bnsv2-api -- base URL is api.bnsv2.com

@diwakergupta
Copy link
Member

There's also https://github.com/Strata-Labs/bns-v2-sdk if that's easier to integrate with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants