New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs containing colons aren't detected properly #7

Open

kainosnoema opened this issue May 21, 2014 · 1 comment

kainosnoema commented May 21, 2014

Example: a Wikimedia URL such as http://en.wikipedia.org/wiki/File:Hanyu_trad_simp.svg is linked as http://en.wikipedia.org/wiki/File:Hanyu_trad_simp.svg.

According to RFC3986, a colon is a valid character in segments, query strings and fragments: http://tools.ietf.org/html/rfc3986#section-3.3

StianOvrevage commented Aug 21, 2014

I have created a PR that fixes this issue. Hopefully it will get merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment