Escape all string values in broken json from php-fpm status #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! :-) Is there anything else missing in the PR? I'd be more than happy to fix whatever is needed. Thank you! |
|
Hi! :-) Is there something that I can/need to add to the branch so it can be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-fpm status page sends a broken json where string values are not escaped.
eg:
"user":"myval\srv_monitor"There is a current fix in place specifically for the
request urifield.This pull request extends this fix to all string fields in the JSON response.
The problem with broken JSON is that only with regexes we cannot reliably split the JSON and extract the strings.
The strategy is to break down the string to get the values between field names in the form
"user":, detect the values that are of type string and apply the samejson.Marshallescaping.Should fix #258 and #291