Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 17+ #46

Closed
fwolff opened this issue Dec 18, 2020 · 1 comment · Fixed by #64
Closed

Support React 17+ #46

fwolff opened this issue Dec 18, 2020 · 1 comment · Fixed by #64

Comments

@fwolff
Copy link

fwolff commented Dec 18, 2020

Hi,

It would be nice to support React 17+.

  "peerDependencies": {
    "prop-types": "^15.6.0",
    "react": "^15.5.4 || ^16.0.0 || ^17.0.0",
    "react-dom": "^15.5.4 || ^16.0.0 || ^17.0.0",
    "react-router-dom": "^4.1.1 || ^5.0.1"
  },

Thanks.
@benjih
Copy link

benjih commented Feb 12, 2021

I just had a quick attempt at performing this change to support React 17 and the first issue I came across is that enzyme does not support React 17 yet. Once this is merged in (enzymejs/enzyme#2430) and they've released, more than happy to take another look at this if no one else beats me to it.

@entozoon entozoon mentioned this issue May 13, 2021
Closed
@tigerabrodi tigerabrodi mentioned this issue May 17, 2021
Closed
@joealden joealden mentioned this issue Aug 22, 2021
Merged
@hinok hinok closed this as completed in #64 Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly Support React 17
2 participants
@fwolff @benjih