Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPO2: Call total_episode_reward_logger before incrementing num_timesteps #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balintkozma
Copy link

@balintkozma balintkozma commented Nov 14, 2019

Description

In ppo2.py total_episode_reward_logger should be called before incrementing num_timesteps. See explanation in #143.

Motivation and Context

It improves the reported episode reward logging issue, and a PR was asked.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@araffin araffin added the PR template not filled Please fill the pull request template label Nov 14, 2019
@araffin
Copy link
Collaborator

araffin commented Nov 14, 2019

Hello,

Please fill in the PR template completely.

@balintkozma balintkozma changed the title Call total_episode_reward logger before incrementing num_timesteps Call total_episode_reward_logger before incrementing num_timesteps Nov 14, 2019
@balintkozma balintkozma force-pushed the ppo2_episode_reward_logger branch from d674c80 to b053747 Compare November 14, 2019 15:42
@balintkozma balintkozma changed the title Call total_episode_reward_logger before incrementing num_timesteps PPO2: Call total_episode_reward_logger before incrementing num_timesteps Nov 14, 2019
@araffin araffin removed the PR template not filled Please fill the pull request template label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants