Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] [feature request] DDPG VecEnv support #679

Closed
Enderdead opened this issue Feb 4, 2020 · 3 comments
Closed

[question] [feature request] DDPG VecEnv support #679

Enderdead opened this issue Feb 4, 2020 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Enderdead
Copy link

I'm currently working to speed up a project using the stable-baselines DDPG algorithm. My environment can be easily converted into VecEnv. But I figured out that your DDPG doesn't support the VecEnv.
I'm wondering why you didn't implement it? Lack of time, hard to deal with?
Thank you in advance.

@araffin araffin added question Further information is requested enhancement New feature or request labels Feb 4, 2020
@araffin
Copy link
Collaborator

araffin commented Feb 4, 2020

Hello,

Duplicate of #170 (related to #495 )

In short, SAC/TD3/DDPG were designed for using them on real robot, so where multiprocessing is not possible. I would recommend using PPO/A2C for fast training using massive multiprocessing (where sample efficiency is not a problem but wall clock time is)

In theory, SAC/TD3/DDPG could be extended to multiprocessing (this will maybe easier to do so with v3 #576 ), however, in practice, this would complicate the current code (maybe a wrapper around the replay buffer would be a solution).

@araffin araffin closed this as completed Feb 4, 2020
@m-rph
Copy link

m-rph commented Feb 11, 2020

Perhaps this is solved with #684 ?

@araffin
Copy link
Collaborator

araffin commented Feb 11, 2020

Perhaps this is solved with #684 ?

Only partially solved, we would need to change all the logging around (this would complexify the code a bit) and for some algorithm (like DDPG), we are using a UnvecWrapper (for legacy reason, not planned in the next version) to have only one environment, so switching to a VecEnv may break other things unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants