Hello, Http Server integration #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
juanpedromoreno
changed the base branch from
master
to
feature/182-http-support-from-protocols
fedefernandez
approved these changes
Mar 19, 2018
pepegar
pushed a commit
that referenced
this pull request
Jul 18, 2018
rafaparadela
pushed a commit
that referenced
this pull request
Mar 8, 2019
* Initial steps for http integration (#203) * Implemented sample client and server REST handlers to be generated * Added monix.Observable implementation This is basically a conversion to/from the internal fs2.Stream. * Implemented error handling for unary and streaming REST services (#258) * Tentative fix for the hanging Monix-Observable tests * Undo Single Abstract Method syntax to restore 2.11 compatibility * Add auto-derived HTTP client implementation, move packages Note: Update of Monix/FS2 conversions is in progress with some outdated implementations removed, which fails several tests. * Fix Monix/FS2 conversions using updated dependency * fixes Scala 2.11 compilation error * fixes unit tests to prove http client derivation * removes some println * adds more tests * removes the macro params that can be inferred * builds the client according to the typology of the request * fixes macro * advances with client derivation * adds more unit test to prove the derived http client * restores the derivation of the rpc server, without the refactoring * re-applies part of the refactoring little by little * applies the refactoring again with the fix * derived the simplest http route that only serves GET calls * derived the stream reaquests http server * fixes the binding pattern in POST routes * adds tests to cover all the possible types of endpoints * removes unused imports * removed unused HttpMethod * upgraded http4s and moved Utils * solves all the comments in code review * expressed type as FQN and propagated encoder/decoders constraints * removes the import of monix.Scheduler in the macro * replaces executionContext by Schedule at some points * adds _root_ to ExecutionContext * Apply suggestions from code review * removes circe-generic * replaces Throwable by UnexpectedError and its encoder/decoder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #182
This is a very beginning for supporting HTTP auto-derived endpoints from RPC protocols: