-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save all tabs from all windows #19
Comments
Hey @pquerner curious what you'd expect to see when opening up a tab group that was saved from multiple windows.
|
Hello @hharnisc If you look at the Chrome extension "Session Buddy" you'll see that it saves the tabs within the used windows. So you may have different Windows of Google Chrome with specific Tabs open (ie. one is for music, one is for work related stuff etc.) If you then click to save / sync the tabs, it'll just not only sync the tabs from this current Window you clicked the extensions icon from, but all the other Windows tabs, too. |
Got it! I took a look a the chrome tabs api and it looks like we can get the window id for each tab. So this is certainly possible. https://developer.chrome.com/extensions/tabs#type-Tab Thinking a bit about the underlying tab data structure. The current one is too simple, looks sort of like this: [
{
"name": "My Tab Group",
"tabs": [
"https://google.com",
"https://test.com",
]
}
] There's not really a way to know which tabs belong to which window. I think if I modify it like this it would make it possible to add the ability to save tab <-> window mappings (and also solve pinned tabs from #13) [
{
"name": "My Tab Group",
"windows": [
{
"tabs": [
{
"pinned": false,
"url": "https://google.com"
}
]
}, {
"tabs": [
{
"pinned": true,
"url": "https://test.com"
}
]
}
]
}
] |
Might be a little tricky even further. |
Perhaps it could default to storing it locally (the Otherwise, you could also look into a less verbose data storage method like protobufs, or some third-party cloud storage. |
Curious @arkon, have you experienced the 1KB limit? I wonder how many tab groups that is, and if (more likely when) this has happened yet. |
@hharnisc I haven't been using Tabbie that much, so I certainly haven't been anywhere close to hitting the 1KB limit. Frankly, 1KB seems like a pretty big amount for JSON, but even if it is a concern, there are definitely ways to design the data set such that it takes up less room. |
See title.
The text was updated successfully, but these errors were encountered: