From e3cc81607247c055116240fb71d52a7397ccc65c Mon Sep 17 00:00:00 2001 From: Schneems Date: Thu, 5 Sep 2024 12:33:34 -0500 Subject: [PATCH] Fix clippy and doc tests ``` error: the borrowed expression implements the required traits --> ruby_executable/src/bin/ruby_build.rs:143:24 | 143 | docker_run.arg(&format!( | ________________________^ 144 | | "./make_ruby.sh {} {}", 145 | | input_tar.display(), 146 | | output_tar.display() 147 | | )); | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]` help: change this to | 143 ~ docker_run.arg(format!( 144 + "./make_ruby.sh {} {}", 145 + input_tar.display(), 146 + output_tar.display() 147 ~ )); | error: could not compile `ruby_executable` (bin "ruby_build" test) due to 1 previous error warning: build failed, waiting for other jobs to finish... ``` --- jruby_executable/src/lib.rs | 4 ++-- ruby_executable/src/bin/ruby_build.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/jruby_executable/src/lib.rs b/jruby_executable/src/lib.rs index 6f33d5d..ac597c8 100644 --- a/jruby_executable/src/lib.rs +++ b/jruby_executable/src/lib.rs @@ -9,14 +9,14 @@ /// implements Ruby 3.1.4 stdlib. When people use jruby they specify both the /// jruby version and the stdlib version, for example: /// -/// ```ignore +/// ```ruby /// # Gemfile /// ruby "3.1.4", engine: "jruby", engine_version: "9.4.3.0" /// ``` /// /// Example file for /// -/// ```ignore +/// ```ini /// # Defaults. To override, create a file called build.properties in /// # the same directory and put your changes in that. /// #src.dir=src diff --git a/ruby_executable/src/bin/ruby_build.rs b/ruby_executable/src/bin/ruby_build.rs index 043ce0c..eedabf0 100644 --- a/ruby_executable/src/bin/ruby_build.rs +++ b/ruby_executable/src/bin/ruby_build.rs @@ -140,7 +140,7 @@ fn ruby_build(args: &RubyArgs) -> Result<(), Box> { docker_run.arg(&image_name); docker_run.args(["bash", "-c"]); - docker_run.arg(&format!( + docker_run.arg(format!( "./make_ruby.sh {} {}", input_tar.display(), output_tar.display()