Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adds fir pilot language to match the dashboard when create a fir space #3114

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Feat: Adds fir pilot language to match the dashboard when create a fir space #3114

merged 2 commits into from
Dec 3, 2024

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Dec 2, 2024 •
edited
Loading

To test

  1. checkout build etc.
  2. Create a fir space. heroku space:create --generation fir ...other flags and args
  3. Observe the fir pilot language is output to the terminal
image

@justinwilaby justinwilaby requested a review from a team as a code owner December 2, 2024 18:24
@justinwilaby justinwilaby changed the base branch from main to prerelease/10.0.0-alpha December 2, 2024 18:25
k80bowman
k80bowman requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works great, just have a formatting question.

packages/cli/src/commands/spaces/create.ts Outdated Show resolved Hide resolved
k80bowman
k80bowman approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@justinwilaby justinwilaby merged commit ca4f120 into prerelease/10.0.0-alpha Dec 3, 2024
8 checks passed
@justinwilaby justinwilaby deleted the jw/fir/add-pilot-language branch December 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k80bowman k80bowman k80bowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinwilaby @k80bowman