Improve tutorial rundoc determinism #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
rundoc-determinism
branch
from
1a86262 to
1a6ca1a
Compare
|
For what this looks like, see: (I've triggered it from this branch) |
edmorley
force-pushed
the
rundoc-determinism
branch
from
1a6ca1a to
1026c6d
Compare
To try and prevent PRs being opened every week even if nothing has actually changed. Specifically: - Uses `--pull-policy if-not-present` to avoid the builder image SHA from ended up in the logs. - Replaces timestamps, bundler output, image digests etc in the `pack build` output - Uses a fake image digest in the `docker image ls` output
edmorley
force-pushed
the
rundoc-determinism
branch
from
1026c6d to
e3c2087
Compare
|
After merging the latest updates PR, and then triggering the updater again - it now correctly no-ops with no changes (and thus no new PR): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To try and prevent PRs being opened every week even if nothing has actually changed.
Specifically:
--pull-policy if-not-presentto avoid the builder image SHA from ended up in the logs.pack buildoutput.docker image lsoutput.GUS-W-17029412.