Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Do not set BROKER_TRANSPORT #26

Open
dcramer opened this issue Feb 10, 2015 · 5 comments
Open

Do not set BROKER_TRANSPORT #26

dcramer opened this issue Feb 10, 2015 · 5 comments

Comments

@dcramer
Copy link

dcramer commented Feb 10, 2015

I'm not entirely sure the purpose of this setting, but it seems in (at least) Celery 3.1 it should not be configured, or it should be configured with something else (I think just 'redis'). I've never ever had to configure this myself, so it's probably better to just remove this configuration.

Setting it to None before Flask-Heroku inits resolves the issue, as it prevents it from setting it.

@singingwolfboy
Copy link
Contributor

This seems like it could break backwards compatibility. Does it actually cause problems for you?

@dcramer
Copy link
Author

dcramer commented Apr 22, 2015

I dont recall the exception, but yes, it caused issues of some sorts.

@singingwolfboy
Copy link
Contributor

Hm. I'd rather not break backwards compatibility without some documented reason. If you ever run into this issue again, can you report the exception you saw? If you don't have an actual traceback, it might make sense to just close this issue for now.

@dcramer
Copy link
Author

dcramer commented Apr 22, 2015

You might consider the inverse: where in Celery documentation does it say you should ever set this?

http://celery.readthedocs.org/en/latest/configuration.html#broker-transport

It doesnt even tell you the use here.

Literally all that needs set is BROKER_URL which is being taken care of.

Moreso, the BROKER_TRANSPORT setting doesn't get configured when you use RabbitMQ, so why would it get set when using Redis?

@dcramer
Copy link
Author

dcramer commented Apr 22, 2015

https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=BROKER_TRANSPORT

If i had to guess, I'd say this setting has been deprecated since 2.3.0, and setting both in current versions is definitely incorrect (and no one uses 2.3.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants