You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Considering that pub mod virtqueue, and new is also a pub function. I assume that users can directly call this function. This potential situation could result in *(self.mem as *const u16) being dereference a null pointer, and directly dereferencing it might trigger undefined behavior (UB). For safety reasons, I felt it necessary to report this issue. If you have performed checks elsewhere that ensure this is safe, please don’t take offense at my raising this issue.
I suggest Several possible fixes:
If there is no external usage for Vring or new, they should not marked as pub, at least its new should not marked as pub
new method should add additional check for null pointer.
mark new method as unsafe and proper doc to let users know that they should provide valid Pointers.
The text was updated successfully, but these errors were encountered:
Hello, thank you for your contribution in this project, I am scanning the unsoundness problem in rust project.
I notice the following code:
Considering that
pub mod virtqueue
, andnew
is also a pub function. I assume that users can directly call this function. This potential situation could result in*(self.mem as *const u16)
being dereference a null pointer, and directly dereferencing it might trigger undefined behavior (UB). For safety reasons, I felt it necessary to report this issue. If you have performed checks elsewhere that ensure this is safe, please don’t take offense at my raising this issue.I suggest Several possible fixes:
Vring
ornew
, they should not marked aspub
, at least itsnew
should not marked aspub
new
method should add additional check for null pointer.The text was updated successfully, but these errors were encountered: