Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No architecture-agnostic variant of PhysAddr used #641

Closed
jounathaen opened this issue Feb 19, 2024 · 3 comments
Closed

No architecture-agnostic variant of PhysAddr used #641

jounathaen opened this issue Feb 19, 2024 · 3 comments
Assignees
@mkroening

Comments

@jounathaen
Copy link
Member

We need a HW-agnostic variant of PhysAddr.

          This breaks AArch64, but that's fine for now, I guess. I'm already working on a unified crate for `PhysAddr` and `VirtAddr` for all architectures, which we can adapt later.

Originally posted by @mkroening in #527 (comment)
@mkroening mkroening self-assigned this Feb 19, 2024
@mkroening mkroening mentioned this issue Feb 19, 2024
Merged
@jounathaen jounathaen mentioned this issue Mar 12, 2024
Merged
@jounathaen
Copy link
Member Author

I have added an aarch64 version in #657, but a global solution would still be preferred.

@jounathaen jounathaen changed the title PhysAddr breaks AArch64 No architecture agnostic variant of PhysAddr Apr 3, 2024
@jounathaen jounathaen changed the title No architecture agnostic variant of PhysAddr No architecture-agnostic variant of PhysAddr used Apr 3, 2024
@n0toose n0toose mentioned this issue Jun 12, 2024
Open
@jounathaen
Copy link
Member Author

I suggested this feature to the x86_64 crate: rust-osdev/x86_64#498

@jounathaen
Copy link
Member Author

Implemented in 428eec4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jounathaen @mkroening