Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Version with HTTP2 support doesn't appear to be published on jitpack #33

Open
fkurniaw opened this issue Oct 18, 2020 · 15 comments

Comments

@fkurniaw
Copy link

When I bundle the oksse library as part of my android app, I get an issue where the list of protocols available is limited to only http/1.1

However, I've been explicitly passing in an OkHttpClient that has h2 as part of the protocols

Seems like the PR here isn't included in the library that was published to jitpack #25

@lbdroid
Copy link

lbdroid commented Apr 13, 2021

This is a dead project. Use the SSE features built into okhttp as okhttp-sse.

@vitalyster
Copy link

@lbdroid okhttp-sse does not reconnect - square/okhttp#5471

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

@vitalyster : Nothing stopping you from performing your own reconnect from onClosed() and onFailure().

@vitalyster
Copy link

vitalyster commented Jun 28, 2021

@lbdroid nothing stopping me writing my own library, but SSE support in okhttp-sse is broken and incomplete, while everything is ok in oksse

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

Its not broken, and incomplete doesn't matter if it does what is needed. oksse is both broken and unsupported, which makes it a non-starter no matter how you look at it.

@vitalyster
Copy link

@lbdroid automatic reconnection is a key feature of SSE standard, so okhttp-sse is broken(incomplete) and can not be used until the issue is not fixed

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

Cry me a river. Its ONE LINE in your own code to make it automatically reconnect.

@vitalyster
Copy link

Go and fix okhttp-sse then and stop that flood

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

Why would I waste my time fixing something that doesn't need to be fixed?

@vitalyster
Copy link

It should be fixed, because that library does not implement key feature of the standard it tries to implement

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

What is your point? Are you advertising for this broken and unmaintained crap project?

@vitalyster
Copy link

This project works perfectly and I'm pointing out key feature, while you are repeating FUD.

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

This project hasn't seen a commit in 3 years. It does NOT work, and it uses a horrendously out of date and non-secure version of okhttp.

@vitalyster
Copy link

It works absolutely correct and you can use any version of okhttp with it, learn how to manage dependencies before writing misinformation.

@lbdroid
Copy link

lbdroid commented Jun 28, 2021

Come back when you reach adulthood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants