ENH: TocDict class for results #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
reviewed
Sep 11, 2023
ntessore
changed the title
paddyroddy
approved these changes
Sep 11, 2023
ntessore
added a commit
that referenced
this pull request
Sep 12, 2023
Changes the package layout to include a `heracles.core` module for shared functionality (e.g. `TocDict`, #30). This improves import performance a little, since not all imports from `heracles.util` are always needed (timing-related functionality). Where `heracles.util` functionality is conditionally used, the import is moved into the function definition, instead of being a global import. Reviewed-by: Patrick Roddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
TocDictclass, which is a dictionary with fancy indexing. TheTocDictclass is used for results from various functions.Closes: #29
Reviewed-by: Patrick Roddy [email protected]