Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications from editordialog failures not appearing #2655

Closed
skoeva opened this issue Dec 10, 2024 · 0 comments · Fixed by #2674
Closed

Notifications from editordialog failures not appearing #2655

skoeva opened this issue Dec 10, 2024 · 0 comments · Fixed by #2674
Assignees
@skoeva
Labels
bug Something isn't working frontend Issues related to the frontend regression Bugs for things that used to work in previous releases.

Comments

@skoeva
Copy link
Contributor

skoeva commented Dec 10, 2024

Title. Success notifications appear but failure notifications do not.

To Reproduce

Steps to reproduce the bug:
Try to create a resource in Headlamp with an invalid name (something like resource!)

Are you able to fix this issue?

I can help with this
@skoeva skoeva added bug Something isn't working frontend Issues related to the frontend regression Bugs for things that used to work in previous releases. labels Dec 10, 2024
@skoeva skoeva self-assigned this Dec 12, 2024
skoeva added a commit that referenced this issue Dec 12, 2024
@skoeva
frontend: ActionsNotifier: Use unique refKey for errors
913c272 
This change adds a unique refKey for error states, separate from success
states, addressing a regression where failure notifications would not
appear in the UI.

Fixes: #2655

Signed-off-by: Evangelos Skopelitis <[email protected]>
@skoeva skoeva linked a pull request Dec 12, 2024 that will close this issue
frontend: ActionsNotifier: Adjust keys for snackbars #2674
Merged
2 tasks
@skoeva skoeva mentioned this issue Dec 12, 2024
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from Queued to Done in Release Plan / Roadmap Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoeva skoeva

Labels
bug Something isn't working frontend Issues related to the frontend regression Bugs for things that used to work in previous releases.
Projects
Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: ActionsNotifier: Adjust keys for snackbars headlamp-k8s/headlamp
1 participant
@skoeva